Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all locales #331

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update all locales #331

wants to merge 5 commits into from

Conversation

2018D
Copy link

@2018D 2018D commented Nov 10, 2022

What are the relevant tickets?

(Required)

What's this PR do?

Update all language locale to reflect previous code change since 2017.
Added french localization.

How should this be manually tested?

Use edx-sga on a french language platform.

Where should the reviewer start?

(Optional)

Any background context you want to provide?

(Optional)

Screenshots (if appropriate)

(Optional)

What GIF best describes this PR or how it makes you feel?

(Optional)

new strings added by previous updates are now included in the english locale
new strings added by previous updates are now included in the rtl locale
new strings added by previous updates are now included in the fake2 locale
new strings added by previous updates are now included in the eo locale
added fr locale for french language
@pdpinch
Copy link
Member

pdpinch commented Jan 23, 2023

Sorry @2018D I'm not familiar with how translations work. Is this something we should be merging into master? Is it ready for review? How can we test the PR?

@2018D
Copy link
Author

2018D commented Jan 23, 2023

Hello @pdpinch,
It's ready for review and yes it could be merged into master. Though it will not contain strings added/modified since Nov.9.
To test the PR, you would need to have an openedx platform with french enabled with edx-sga installed; have your profile in french to see if translations work properly; i don't quite see how else you'd test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants